pages controller
Reported by stevenbristol | March 6th, 2008 @ 01:06 AM
create & update: why do
@page.user = logged_in? ? current_user : User.new
when you can just do
@page.user = current_user
ALSO
in destroy, why do
@page = Page.find(params[:id])
@page.destroy
instead of
@page = Page.find(params[:id]).destroy
Comments and changes to this ticket
-
Josh Owens March 6th, 2008 @ 02:13 AM
- → State changed from “new” to “open”
On the first question, current_user == false if not logged in. Saving the author name as false is just a bad idea, imo. Not the intended effect.
On the second question. Fixed in git now.
-
Josh Owens March 6th, 2008 @ 02:20 AM
- → State changed from “open” to “resolved”
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
